From ada5ea0c5d4b658d6834f63090dc7e32906a7c9d Mon Sep 17 00:00:00 2001 From: Jasper Date: Sun, 30 Apr 2023 12:11:31 +0200 Subject: [PATCH 1/2] temp fix for "forEach" bug This is a temporary fix for the "Cannot read properties of undefined (reading 'forEach')" bug. This will be fixed in a better way in v3.4.0 --- core/ticketActions/ticketOpener.js | 34 ++++++++++++++++-------------- 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/core/ticketActions/ticketOpener.js b/core/ticketActions/ticketOpener.js index 8d17be8..ab3bfb2 100755 --- a/core/ticketActions/ticketOpener.js +++ b/core/ticketActions/ticketOpener.js @@ -136,21 +136,23 @@ module.exports = () => { * @type {String[]} */ const readonlyTicketadmin = currentTicketOptions.readonlyAdminroles - readonlyTicketadmin.forEach((role,index) => { - if (!config.adminRoles.includes(role) && !currentTicketOptions.adminroles.includes(role)){ - try { - const adminrole = guild.roles.cache.find(r => r.id == role) - if (!adminrole) return - - permissionsArray.push({ - id:adminrole, - type:"role", - allow:[pfb.AddReactions,pfb.ViewChannel], - deny:[pfb.SendMessages,pfb.AttachFiles,pfb.EmbedLinks] - }) - }catch{} - } - }) + if (readonlyTicketadmin){ + readonlyTicketadmin.forEach((role,index) => { + if (!config.adminRoles.includes(role) && !currentTicketOptions.adminroles.includes(role)){ + try { + const adminrole = guild.roles.cache.find(r => r.id == role) + if (!adminrole) return + + permissionsArray.push({ + id:adminrole, + type:"role", + allow:[pfb.AddReactions,pfb.ViewChannel], + deny:[pfb.SendMessages,pfb.AttachFiles,pfb.EmbedLinks] + }) + }catch{} + } + }) + } //add member role if (config.system.memberRole && ![" ","0","false","null","undefined"].includes(config.system.memberRole)){ @@ -241,4 +243,4 @@ module.exports = () => { } } }) -} \ No newline at end of file +} From 7c7c325307cdb4ac6b3964d25e6973edeca0bd0b Mon Sep 17 00:00:00 2001 From: Jasper Date: Mon, 1 May 2023 13:11:34 +0200 Subject: [PATCH 2/2] temp fix for bugs --- README.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/README.md b/README.md index 9e4b73c..2402319 100644 --- a/README.md +++ b/README.md @@ -1,3 +1,7 @@ +### ⚠️ WARNING! +In open ticket **v3.3.3 & below**, there is a bug causing weird looking embeds, we solved this in the [dev branch](https://github.com/DJj123dj/open-ticket/tree/dev). Try to download open ticket from there while we are fixing the bug! +
+ Open Ticket [![discord](https://img.shields.io/badge/discord-join%20our%20server-5865F2.svg?style=flat-square&logo=discord)](https://discord.com/invite/26vT9wt3n3) [![version](https://img.shields.io/badge/version-3.3.3-brightgreen.svg?style=flat-square)](https://github.com/DJj123dj/open-ticket/releases/tag/v3.3.3) [![discord.js](https://img.shields.io/badge/discord.js-v14-CB3837.svg?style=flat-square&logo=npm)]() [![license](https://img.shields.io/badge/license-GPL%203.0-important.svg?style=flat-square)](https://github.com/DJj123dj/open-ticket/blob/main/LICENSE) [![stars](https://img.shields.io/github/stars/djj123dj/open-ticket?color=yellow&label=stars&logo=github&style=flat-square)](https://docs.openticket.dj-dj.be)